Fix BenchmarkTools.DEFAULT_PARAMETERS const assignment error in Julia 1.12 #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1.12 - Remove global modification of BenchmarkTools.DEFAULT_PARAMETERS which fails in Julia 1.12+ due to const restriction - Pass seconds and samples parameters directly to @benchmark macro - Remove try/finally block that was only needed for parameter restoration - Fixes issue SciML#744 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… 1.12 - Remove global modification of BenchmarkTools.DEFAULT_PARAMETERS which fails in Julia 1.12+ due to const restriction - Use @benchmarkable and BenchmarkTools.run with custom parameters - Remove try/finally block that was only needed for parameter restoration - Fixes issue SciML#744 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #744 - resolves const assignment error when setting
BenchmarkTools.DEFAULT_PARAMETERSin Julia 1.12+.In Julia 1.12+,
BenchmarkTools.DEFAULT_PARAMETERSbecame a const and cannot be reassigned. The previous code attempted to:old_params = BenchmarkTools.DEFAULT_PARAMETERSBenchmarkTools.DEFAULT_PARAMETERS.seconds = secondsBenchmarkTools.DEFAULT_PARAMETERS = old_params← This failsChanges
BenchmarkTools.DEFAULT_PARAMETERSBenchmarkTools.Parameterscreation and direct usage via@benchmarkable+BenchmarkTools.runFiles Changed
lib/LinearSolveAutotune/src/benchmarking.jl:90-93: Removed global parameter settinglib/LinearSolveAutotune/src/benchmarking.jl:235-241: Updated benchmark execution to use local parameterslib/LinearSolveAutotune/src/benchmarking.jl:272-277: Removed try/finally blockTesting
Benefits
🤖 Generated with Claude Code