Fix infinite loop when symbolic variables are missing from PDESystem #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475
Problem
When a user forgot to include a symbolic variable in the dependent variables list of PDESystem, the system transformation would enter an infinite loop with endless "Expanding derivatives" warnings.
For example:
This would print endless warnings:
Solution
Added upfront validation in
transform_pde_system!to detect unknown symbolic variables before the transformation loop begins. The implementation:depvar_ops+,-,*,/, etc. andDifferential/IntegralImplementation Details
find_unknown_variables()helper function that traverses symbolic expressionsTesting
PDESystemresults in infinite loop #475 - now throws clear errorExample Before/After
Before:
After:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]