Skip to content

Conversation

@github-actions
Copy link

This pull request changes the compat entry for the ModelingToolkit package from 10.10 to 10.10, 11 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ChrisRackauckas ChrisRackauckas force-pushed the compathelper/new_version/2025-12-31-00-38-48-181-01644361937 branch from 500c381 to 30977fa Compare December 31, 2025 00:38
@ChrisRackauckas-Claude
Copy link

CI Fix Analysis

The CI is failing because of a version conflict between the main Project.toml and test/Project.toml:

Root Cause:

  • test/Project.toml has ModelingToolkit = "10.10, 11" (updated by CompatHelper)
  • Main Project.toml has ModelingToolkit = "10.10" (only v10)
  • The PR branch was created before PR Add PrecompileTools workload to improve TTFX #134 (PrecompileTools) was merged, causing a merge conflict

When CI runs with force_latest_compatible_version=true, it tries to use MTK v11 but the main package compat blocks it.

Required Fixes:

  1. Merge main into this branch to pick up the PrecompileTools changes from PR Add PrecompileTools workload to improve TTFX #134
  2. Update main Project.toml compat for ModelingToolkit from "10.10" to "10.10, 11"

Testing:
I've verified locally that ModelOrderReduction loads and works correctly with ModelingToolkit v11.4.0. The basic POD tests pass.

Note: I don't have push access to apply these fixes directly. A maintainer will need to either:

  • Apply the fix by updating Project.toml line 19 to ModelingToolkit = "10.10, 11" and merging main
  • Or close this PR and create a new one with the proper compat

cc @ChrisRackauckas

🤖 Generated with Claude Code

@ChrisRackauckas-Claude
Copy link

Analysis of CI Failures

The CI failures were due to the PR branch being out of sync with main (missing the PrecompileTools changes from PR #134).

After rebasing onto main and testing locally, I found that:

  1. The main Project.toml also needs the compat update - The original CompatHelper PR only updated test/Project.toml, but the main Project.toml still had ModelingToolkit = "10.10". I've added a commit to also update the main Project.toml to ModelingToolkit = "10.10, 11".

  2. Tests pass with MTK 10 - The tests pass locally with ModelingToolkit v10 (which is what CI will use since MethodOfLines v0.11 doesn't yet support MTK 11).

  3. MTK 11 compatibility is ready for when MethodOfLines supports it - Once MethodOfLines updates its compat to include MTK 11, the test environment will be able to use it.

Unfortunately I don't have push access to the SciML/ModelOrderReduction.jl repository to push fixes to this branch directly. The fixes have been pushed to my fork at:
ChrisRackauckas-Claude/ModelOrderReduction.jl:compathelper/new_version/2025-12-31-00-38-48-181-01644361937

Options:

  1. Someone with push access can cherry-pick my commit to this branch
  2. Close this PR and I can create a new one from my fork

cc @ChrisRackauckas

🤖 Generated with Claude Code

@ChrisRackauckas-Claude
Copy link

I've created a new PR #136 from my fork with the complete fix (rebased onto main + the main Project.toml compat update). If CI passes on #136, this PR can be closed.

🤖 Generated with Claude Code

@ChrisRackauckas ChrisRackauckas deleted the compathelper/new_version/2025-12-31-00-38-48-181-01644361937 branch January 4, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants