Improving coverage.

Author: lamorton

src/systems/optimization/optimizationsystem.jl

@@ -332,7 +332,7 @@ function OptimizationProblemExpr(sys::OptimizationSystem, args...; kwargs...)
     OptimizationProblemExpr{true}(sys::OptimizationSystem, args...; kwargs...)
 end
 
-function OptimizationProblemExpr{iip}(sys::OptimizationSystem, u0,
+function OptimizationProblemExpr{iip}(sys::OptimizationSystem, u0map,
                                       parammap = DiffEqBase.NullParameters();
                                       lb = nothing, ub = nothing,
                                       grad = false,

test/constants.jl

@@ -42,3 +42,5 @@ sys = ODESystem(eqs, name = :sys)
 #    Testing that units checking is bypassed in the constructors
 simp = structural_simplify(sys)
 @test_throws MT.ValidationError MT.check_units(simp.eqs...)
+
+@test MT.collect_constants(nothing) == Symbolics.Sym[]

test/funcaffect.jl

@@ -25,6 +25,8 @@ cb1 = ModelingToolkit.SymbolicDiscreteCallback(t == zr, (affect1!, [], [], [1]))
 @test cb == cb1
 @test ModelingToolkit.SymbolicDiscreteCallback(cb) === cb # passthrough
 @test hash(cb) == hash(cb1)
+ModelingToolkit.generate_discrete_callback(cb, sys, ModelingToolkit.get_variables(sys),
+                                           ModelingToolkit.get_ps(sys));
 
 cb = ModelingToolkit.SymbolicContinuousCallback([t ~ zr],
                                                 (f = affect1!, sts = [], pars = [],

test/optimizationsystem.jl

@@ -27,6 +27,7 @@ generate_gradient(combinedsys)
 generate_hessian(combinedsys)
 hess_sparsity = ModelingToolkit.hessian_sparsity(sys1)
 sparse_prob = OptimizationProblem(sys1, [x, y], [a, b], grad = true, sparse = true)
+OptimizationProblemExpr{true}(sys1, [x => 0, y => 0], [a => 0, b => 0];);
 @test sparse_prob.f.hess_prototype.rowval == hess_sparsity.rowval
 @test sparse_prob.f.hess_prototype.colptr == hess_sparsity.colptr