Merge branch 'master' into myb/defaults

Author: YingboMa

Project.toml

@@ -1,7 +1,7 @@
 name = "ModelingToolkit"
 uuid = "961ee093-0014-501f-94e3-6117800e7a78"
 authors = ["Chris Rackauckas <[email protected]>"]
-version = "5.13.3"
+version = "5.13.4"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

docs/src/index.md

@@ -133,3 +133,12 @@ system:
     - Physics-Informed Neural Network (PINN) training on `PDESystem`
 - [DiffEqOperators.jl](https://github.com/SciML/DiffEqOperators.jl)
     - Automated finite difference method (FDM) discretization of `PDESystem`
+
+## Contributing
+
+- Please refer to the [SciML ColPrac: Contributor's Guide on Collaborative Practices for Community Packages](https://github.com/SciML/ColPrac/blob/master/README.md) for guidance on PRs, issues, and other matters relating to contributing to ModelingToolkit.
+- There are a few community forums:
+    - The #diffeq-bridged channel in the [Julia Slack](https://julialang.org/slack/)
+    - [JuliaDiffEq](https://gitter.im/JuliaDiffEq/Lobby) on Gitter
+    - On the Julia Discourse forums (look for the [modelingtoolkit tag](https://discourse.julialang.org/tag/modelingtoolkit)
+    - See also [SciML Community page](https://sciml.ai/community/)

src/systems/diffeqs/abstractodesystem.jl

@@ -291,6 +291,8 @@ function process_DEProblem(constructor, sys::AbstractODESystem,u0map,parammap;
     u0 = varmap_to_vars(u0map,dvs; defaults=defs)
     p = varmap_to_vars(parammap,ps; defaults=defs)
 
+    length(dvs) == length(u0) || throw(ArgumentError("States ($(length(dvs))) and initial conditions ($(length(u0))) are of different lengths."))
+
     f = constructor(sys,dvs,ps,u0;tgrad=tgrad,jac=jac,checkbounds=checkbounds,
                     linenumbers=linenumbers,parallel=parallel,simplify=simplify,
                     sparse=sparse,eval_expression=eval_expression,kwargs...)

src/systems/nonlinear/nonlinearsystem.jl

@@ -211,6 +211,8 @@ function process_NonlinearProblem(constructor, sys::NonlinearSystem,u0map,paramm
     u0 = varmap_to_vars(u0map,dvs; defaults=defs)
     p = varmap_to_vars(parammap,ps; defaults=defs)
 
+    length(dvs) == length(u0) || throw(ArgumentError("States ($(length(dvs))) and initial conditions ($(length(u0))) are of different lengths."))
+
     f = constructor(sys,dvs,ps,u0;jac=jac,checkbounds=checkbounds,
                     linenumbers=linenumbers,parallel=parallel,simplify=simplify,
                     sparse=sparse,eval_expression=eval_expression,kwargs...)

test/nonlinearsystem.jl

@@ -75,6 +75,8 @@ prob = NonlinearProblem(ns,ones(3),ones(3))
 sol = solve(prob,NewtonRaphson())
 @test sol.u[1] ≈ sol.u[2]
 
+@test_throws ArgumentError NonlinearProblem(ns,ones(4),ones(3))
+
 @variables u F s a
 eqs1 = [
         0 ~ σ*(y-x) + F,

test/odesystem.jl

@@ -230,6 +230,7 @@ for (prob, atol) in [(prob1, 1e-12), (prob2, 1e-12), (prob3, 1e-12)]
     sol = solve(prob, Rodas5())
     @test all(x->≈(sum(x), 1.0, atol=atol), sol.u)
 end
+@test_throws ArgumentError ODEProblem(sys,zeros(5),tspan,p)
 
 @parameters t σ β
 @variables x(t) y(t) z(t)