feat: lexicographically sort equations in structural_simplify
#3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/lex-sort-eqs
branch
from
21faed2 to
124ea24
Compare
|
What's left here? |
AayushSabharwal
force-pushed
the
as/lex-sort-eqs
branch
2 times, most recently
from
622ddd3 to
38da2cc
Compare
|
I have the docs fix ready locally. Waiting on SciML/Catalyst.jl#1251 for tests |
|
That Catalyst PR is now merged. |
AayushSabharwal
force-pushed
the
as/lex-sort-eqs
branch
from
ca5febe to
ea0acd4
Compare
src/systems/systemstructure.jl
Outdated
| neqs = length(eqs) | ||
| symbolic_incidence = symbolic_incidence[eqs_to_retain] | ||
|
|
||
| # sort equations lexicographically to reduce simplification issues |
There was a problem hiding this comment.
Put a structural simplify keyword argument to flag this?
There was a problem hiding this comment.
Sure. Cancelled CI to avoid running it twice
ChrisRackauckas
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.