Skip to content

Conversation

@AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal force-pushed the as/tunable-order branch 2 times, most recently from 4ba9c70 to be5172a Compare September 23, 2024 12:27
@ChrisRackauckas ChrisRackauckas merged commit f36e889 into SciML:master Sep 24, 2024
21 of 25 checks passed
@ChrisRackauckas
Copy link
Member

@isaacsas @TorkelE note this does break a Catalyst test which assumed a parameter order. But now there's more guarantees at least on the order of the tunables, see the docs changes.

@AayushSabharwal AayushSabharwal deleted the as/tunable-order branch September 24, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants