Skip to content

fix: make vars search through arrays of symbolics #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: make vars search through arrays of symbolics #3113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,12 @@ function vars!(vars, O; op = Differential)
if isvariable(O)
return push!(vars, O)
end
if symbolic_type(O) == NotSymbolic() && O isa AbstractArray
for arg in O
vars!(vars, arg; op)
end
return vars
end
!iscall(O) && return vars

operation(O) isa op && return push!(vars, O)
Expand Down
10 changes: 9 additions & 1 deletion test/variable_utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using ModelingToolkit, Test
using ModelingToolkit: value
using ModelingToolkit: value, vars
using SymbolicUtils: <ₑ
@parameters α β δ
expr = (((1 / β - 1) + δ) / α)^(1 / (α - 1))
Expand Down Expand Up @@ -33,3 +33,11 @@ aov = ModelingToolkit.collect_applied_operators(eq, Differential)

ts = collect_ivs([eq])
@test ts == Set([t])

@testset "vars searching through array of symbolics" begin
fn(x, y) = sum(x) + y
@register_symbolic fn(x::AbstractArray, y)
@variables x y z
res = vars(fn([x, y], z))
@test length(res) == 3
end
Loading