CompatHelper: bump compat for JuliaFormatter to 2, (keep existing compat) #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisRackauckas is this good to be merged and released? Currently, ModelingToolkit holds back the JuliaFormatter dependency in Pumas. |
|
@AayushSabharwal why is there a JuliaFormatter dep in the first place? |
|
It's used in |
|
Arguably this is questionable usage in the first place. Neither of those are places where this particularly matters. |
|
Yeah... just remove it. We don't need to format the code we generate, let the user do that if they read it to a file. Or move it to an extension. |
ChrisRackauckas
deleted the
compathelper/new_version/2024-10-17-00-22-58-177-01432485685
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
JuliaFormatterpackage from1.0.47to1.0.47, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.