Skip to content

fixing record from solution for observables in the BifurcationKit extension #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fixing record from solution for observables in the BifurcationKit extension #3161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48dc57
make Observable definition comply with new record_from_solution defin…
vyudu Oct 28, 2024
e27da93
add test
vyudu Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/MTKBifurcationKitExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ struct ObservableRecordFromSolution{S, T}
end
end
# Functor function that computes the value.
function (orfs::ObservableRecordFromSolution)(x, p)
function (orfs::ObservableRecordFromSolution)(x, p; k...)
# Updates the state values (in subs_vals).
for state_idx in 1:(orfs.state_end_idxs)
orfs.subs_vals[state_idx] = orfs.subs_vals[state_idx][1] => x[state_idx]
Expand Down
8 changes: 8 additions & 0 deletions test/extensions/bifurcationkit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,12 @@ let
bf = bifurcationdiagram(bp, PALC(), 2, opts_br)

@test bf.γ.specialpoint[1].param≈0.1 atol=1e-4 rtol=1e-4

# Test with plot variable as observable
pvar = ModelingToolkit.get_var_to_name(fol)[:RHS]
bp = BifurcationProblem(fol, u0, par, bif_par; plot_var = pvar)
opts_br = ContinuationPar(p_min = -1.0,
p_max = 1.0)
bf = bifurcationdiagram(bp, PALC(), 2, opts_br)
@test bf.γ.specialpoint[1].param≈0.1 atol=1e-4 rtol=1e-4
end
Loading