Skip to content

fix: respect checkbounds in build_explicit_observed_function #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix: respect checkbounds in build_explicit_observed_function #3339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/systems/diffeqs/odesystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,15 @@ function build_explicit_observed_function(sys, ts;
oop_fn = Func(args, [],
pre(Let(obsexprs,
return_value,
false))) |> array_wrapper[1] |> oop_mtkp_wrapper |> toexpr
false)), [Expr(:meta, :propagate_inbounds)]) |> array_wrapper[1] |> oop_mtkp_wrapper |> toexpr

if !checkbounds
oop_fn.args[end] = quote
@inbounds begin
$(oop_fn.args[end])
end
end
end
oop_fn = expression ? oop_fn : eval_or_rgf(oop_fn; eval_expression, eval_module)

if !isscalar
Expand All @@ -639,6 +647,18 @@ function build_explicit_observed_function(sys, ts;
wrap_code = mtkparams_wrapper .∘ array_wrapper .∘
wrap_assignments(isscalar, obsexprs),
expression = Val{true})[2]
if !checkbounds
iip_fn.args[end] = quote
@inbounds begin
$(iip_fn.args[end])
end
end
end
iip_fn.args[end] = quote
$(Expr(:meta, :propagate_inbounds))
$(iip_fn.args[end])
end

if !expression
iip_fn = eval_or_rgf(iip_fn; eval_expression, eval_module)
end
Expand Down
Loading