Skip to content

fix: don't use === for comparison in variable metadata tests #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: don't use === for comparison in variable metadata tests #3463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/test_variable_metadata.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,30 +54,30 @@ end

# Guess
@variables y [guess = 0]
@test getguess(y) === 0
@test hasguess(y) === true
@test getguess(y) == 0
@test hasguess(y) == true
@test ModelingToolkit.dump_variable_metadata(y).guess == 0

# Default
@variables y = 0
@test ModelingToolkit.getdefault(y) === 0
@test ModelingToolkit.hasdefault(y) === true
@test ModelingToolkit.getdefault(y) == 0
@test ModelingToolkit.hasdefault(y) == true
@test ModelingToolkit.dump_variable_metadata(y).default == 0

# Issue#2653
@variables y[1:3] [guess = ones(3)]
@test getguess(y) == ones(3)
@test hasguess(y) === true
@test hasguess(y) == true
@test ModelingToolkit.dump_variable_metadata(y).guess == ones(3)

for i in 1:3
@test getguess(y[i]) == 1.0
@test hasguess(y[i]) === true
@test hasguess(y[i]) == true
@test ModelingToolkit.dump_variable_metadata(y[i]).guess == 1.0
end

@variables y
@test hasguess(y) === false
@test hasguess(y) == false
@test !haskey(ModelingToolkit.dump_variable_metadata(y), :guess)

# Disturbance
Expand Down
Loading