Skip to content

Fix depwarn due to wrapping Vararg directly in UnionAll #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Fix depwarn due to wrapping Vararg directly in UnionAll #3506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd60c91
fix: fix depwarn due to wrapping `Vararg` directly in `UnionAll`
SebastianM-C Mar 26, 2025
cca1ea1
refactor: format
AayushSabharwal Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/systems/connectors.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ ignored. All analysis points in `ignored_system_aps` must contain systems (conne
as their input/outputs.
"""
function systems_to_ignore(ignored_system_aps::Vector{HierarchyAnalysisPointT},
systems::Union{Vector{<:AbstractSystem}, Tuple{Vararg{<:AbstractSystem}}})
systems::Union{Vector{S}, Tuple{Vararg{S}}}) where {S <: AbstractSystem}
to_ignore = HierarchySystemT[]
for ap in ignored_system_aps
# if `systems` contains the input of the AP, ignore any outputs of the AP present in it.
Expand Down Expand Up @@ -476,7 +476,7 @@ points to be ignored. All analysis points in `ignored_system_aps` must contain v
as their input/outputs.
"""
function variables_to_ignore(ignored_variable_aps::Vector{HierarchyAnalysisPointT},
systems::Union{Vector{<:AbstractSystem}, Tuple{Vararg{<:AbstractSystem}}})
systems::Union{Vector{S}, Tuple{Vararg{S}}}) where {S <: AbstractSystem}
to_ignore = HierarchyVariableT[]
for ap in ignored_variable_aps
ivar_hierarchy = HierarchyVariableT([ap[1].input; @view ap[2:end]])
Expand All @@ -503,7 +503,7 @@ be ignored. All analysis points in `ignored_system_aps` must contain variables a
input/outputs.
"""
function variables_to_ignore(ignored_variable_aps::Vector{HierarchyAnalysisPointT},
vars::Union{Vector{<:BasicSymbolic}, Tuple{Vararg{<:BasicSymbolic}}})
vars::Union{Vector{S}, Tuple{Vararg{S}}}) where {S <: BasicSymbolic}
to_ignore = eltype(vars)[]
for ap in ignored_variable_aps
ivar_hierarchy = HierarchyVariableT([ap[1].input; @view ap[2:end]])
Expand Down
Loading