Skip to content

Change of Variables with units #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

Change of Variables with units #3595

merged 2 commits into from
May 3, 2025

Conversation

@aml5600
Copy link
Contributor

@aml5600 aml5600 commented May 2, 2025 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Adds units to change-of-variables variables if original system has units. Unit test was added.

@aml5600 aml5600 changed the title Andrew/change of vars units Change of Variables with units May 2, 2025
@aml5600
Copy link
Contributor Author

aml5600 commented May 2, 2025

FYI @hersle , apologies I fell off the grid for a bit!

@ChrisRackauckas ChrisRackauckas merged commit 7a9c17f into SciML:master May 3, 2025
31 of 45 checks passed
@hersle
Copy link
Contributor

hersle commented May 3, 2025

Thanks for the notice! Very nice to see this working 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aml5600 @hersle @ChrisRackauckas