Skip to content

Conversation

@hersle
Copy link
Contributor

@hersle hersle commented May 12, 2025

@aml5600 I found your Slack question. I also need it to work with array variables 😅
I think this should work. Thanks for writing the test!

Note that I don't use the @mtkmodel macro in the test.
I'm not completely sure how it works with the NoValue() stuff.
I'm sure there is a way to get that to work, too, which might be unrelated to change_independent_variable (?)

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@hersle hersle force-pushed the change_ivar_array branch from 73a0c3e to 08a846e Compare May 12, 2025 10:17
@aml5600
Copy link
Contributor

aml5600 commented May 12, 2025

@hersle yeah, I would imagine the NoValue stuff is orthogonal to the transformation. Unfortunately I used @mtkmodel heavily while learning MTK and still have it used quite a lot =/

This is a good step forward though, thank you!

@hersle hersle force-pushed the change_ivar_array branch from 08a846e to 38dddbe Compare May 12, 2025 16:38
@hersle
Copy link
Contributor Author

hersle commented May 13, 2025

This is ready now @ChrisRackauckas.
Would be nice to get this in together with #3625.

@ChrisRackauckas ChrisRackauckas merged commit a082d8a into SciML:master May 13, 2025
33 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants