-
-
Notifications
You must be signed in to change notification settings - Fork 233
refactor: significantly improve performance of *Problem generation
#3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: significantly improve performance of *Problem generation
#3751
Conversation
d532cab to
ce25349
Compare
|
Well benchmarks taking this long is weird. It ran in a reasonable amount of time on my system. I'll investigate. |
|
Okay I must have run it on a lower These are the results from this 3 hour run: Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
So yeah, this PR does help quite a bit. Note that even with the changes to make the benchmark less insane, this PR will still take a while to run because master will take a while to run. |
|
Turns out that the trivial tearing optimization wasn't actually implemented correctly and wasn't even doing anything - so that 2.73x performance improvement is about to get a whole lot better. |
bcadee8 to
194ebc7
Compare
…tem` Simplification doesn't care for metadata, so this is unnecessary and expensive.
…alization_problem`
…binding_update_u0_p`
194ebc7 to
1fbff9b
Compare
1fbff9b to
2efd558
Compare
|
This is finally good to go. I've verified that the MTKStdlib failures are due to different guesses being required because the way the initialization is formulated changed. The failing initializations are still fully determined, and with the additional guesses they pass tests. Benchmark Results (Julia vlts)###Time benchmarks
Memory benchmarks
Which is amazing! The big numbers are absurd and get more absurd if the benchmark problem increases in size. |
Viva la Tracy.jl