- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 233
allow DataInterpolations@7 #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Benchmark Results (Julia vlts)Time benchmarks
 Memory benchmarks
 | 
| Benchmark Results (Julia v1)Time benchmarks
 Memory benchmarks
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just a test dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail - we're using some deprecated kwargs.
| oops. That was a bad race condition. Sorry @AayushSabharwal I'll revert. | 
| that said, why would this cause tests to fail? were we stuck on v6 before? | 
| We just didn't update to v7 or v8. Tests fail because they use a kwarg that is removed in later version. | 
| now I'm confused. These tests ran on DataInterpolations v8, so this PR wasn't responsible for failures? Rather than reverting, should we just remove the use of deprecated kwargs? | 
| This PR bumped compat but didn't update tests. So tests failed because they used removed functionality. The PR just needs to update tests and up the lower bound. | 
| ah right. Somehow I got it in my head that v8 was already supported prior to this PR, but that's just nonesense. Followup PR incoming | 
No description provided.