Skip to content

fix: fix parameter dependencies dependent on scalarized array parameter #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

fix: fix parameter dependencies dependent on scalarized array parameter #3822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ae3dda
fix: fix parameter dependencies dependent on scalarized array parameter
AayushSabharwal Jul 16, 2025
8a5d6a0
test: test parameter dependencies with scalarized array RHS
AayushSabharwal Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/systems/abstractsystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2757,7 +2757,9 @@ function process_parameter_equations(sys::AbstractSystem)
is_parameter(sys, sym) ||
symbolic_type(sym) == ArraySymbolic() &&
is_sized_array_symbolic(sym) &&
all(Base.Fix1(is_parameter, sys), collect(sym))
all(Base.Fix1(is_parameter, sys), collect(sym)) ||
iscall(sym) &&
operation(sym) === getindex && is_parameter(sys, arguments(sym)[1])
end
# Everything in `varsbuf` is a parameter, so this is a cheap `is_parameter`
# check.
Expand Down
9 changes: 9 additions & 0 deletions test/parameter_dependencies.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,12 @@ end
[x(k - 1) ~ x(k) + y(k) + p2, p2 ~ 2p1], t)
@test is_parameter(sys, p1)
end

@testset "Scalarized array as RHS of parameter dependency" begin
@parameters p[1:2] p1 p2
@variables x(t)
@named sys = System([D(x) ~ x, p1 ~ p[1], p2 ~ p[2]], t)
@test any(isequal(p), ModelingToolkit.get_ps(sys))
sys = mtkcompile(sys)
@test length(ModelingToolkit.parameter_dependencies(sys)) == 2
end
Loading