Remove outdated Julia version checks from tests #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Julia v1.10 is now the LTS version, remove conditional code for: - Julia v1.7 check in test/clock.jl - Julia v1.5 check in test/direct.jl - Julia v1.8 check in test/input_output_handling.jl These version checks are no longer necessary as the minimum supported Julia version is now well above these thresholds. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Per review feedback, completely remove the code that was inside version checks rather than just removing the conditionals. This removes unnecessary test code for Julia versions below v1.10. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/clock.jl,test/direct.jl,test/input_output_handling.jlDetails
Since the current LTS is Julia v1.10, version checks for older Julia versions (v1.5, v1.7, v1.8) are no longer needed. This PR removes these conditional branches to simplify the test code.
Test plan
🤖 Generated with Claude Code