Skip to content

Fix deprecated ODESystem and @mtkbuild usage in documentation examples #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Fix deprecated ODESystem and @mtkbuild usage in documentation examples #3856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e3a6b8
Fix deprecated ODESystem and @mtkbuild usage in README examples
claude Jul 30, 2025
5d03220
Fix deprecated @mtkbuild usage in demo.jl
claude Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ eqs = [D(D(x)) ~ σ * (y - x),
D(y) ~ x * (ρ - z) - y,
D(z) ~ x * y - β * z]

@mtkbuild sys = ODESystem(eqs, t)
@mtkcompile sys = System(eqs, t)

u0 = [D(x) => 2.0,
x => 1.0,
Expand Down Expand Up @@ -83,13 +83,13 @@ eqs = [D(x) ~ σ * (y - x),
D(y) ~ x * (ρ - z) - y,
D(z) ~ x * y - β * z]

@named lorenz1 = ODESystem(eqs, t)
@named lorenz2 = ODESystem(eqs, t)
@named lorenz1 = System(eqs, t)
@named lorenz2 = System(eqs, t)

@variables a(t)
@parameters γ
connections = [0 ~ lorenz1.x + lorenz2.y + a * γ]
@mtkbuild connected = ODESystem(connections, t, systems = [lorenz1, lorenz2])
@mtkcompile connected = System(connections, t, systems = [lorenz1, lorenz2])

u0 = [lorenz1.x => 1.0,
lorenz1.y => 0.0,
Expand Down
12 changes: 6 additions & 6 deletions demo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ using ModelingToolkit: t_nounits as t, D_nounits as D
eqs = [D(D(x)) ~ λ * x
D(D(y)) ~ λ * y - g
x^2 + y^2 ~ 1]
@mtkbuild pend = System(eqs, t)
@mtkcompile pend = System(eqs, t)
prob = ODEProblem(pend, [x => -1, y => 0], (0.0, 10.0), [g => 1], guesses = [λ => 1])

sol = solve(prob, FBDF())
Expand All @@ -37,7 +37,7 @@ eqs = [
D(z) ~ x * y - β * z + 0.1z * a
]

@mtkbuild sys1 = System(eqs, t)
@mtkcompile sys1 = System(eqs, t)

eqs = [
D(x) ~ σ * (y - x),
Expand All @@ -49,7 +49,7 @@ noiseeqs = [0.1*x;
0.1*y;
0.1*z;;]

@mtkbuild sys2 = SDESystem(eqs, noiseeqs, t)
@mtkcompile sys2 = SDESystem(eqs, noiseeqs, t)

u0 = [
x => 1.0,
Expand All @@ -73,7 +73,7 @@ odeprob = ODEProblem(sys1, u0, (0.0, 10.0), p; check_compatibility = false)
eqs = [0 ~ σ * (y - x),
y ~ x * (ρ - z),
β * z ~ x * y]
@mtkbuild sys = System(eqs)
@mtkcompile sys = System(eqs)

## ImplicitDiscrete Affects

Expand All @@ -83,7 +83,7 @@ eqs = [D(D(x)) ~ λ * x
D(D(y)) ~ λ * y - g
x^2 + y^2 ~ 1]
c_evt = [t ~ 5.0] => [x ~ Pre(x) + 0.1]
@mtkbuild pend = System(eqs, t, continuous_events = c_evt)
@mtkcompile pend = System(eqs, t, continuous_events = c_evt)
prob = ODEProblem(pend, [x => -1, y => 0], (0.0, 10.0), [g => 1], guesses = [λ => 1])

sol = solve(prob, FBDF())
Expand All @@ -104,4 +104,4 @@ function SysC(; name)
@named subsys = SysB(; var1 = x)
return System([D(x) ~ x], t; systems = [subsys], name)
end
@mtkbuild sys = SysC()
@mtkcompile sys = SysC()
Loading