Skip to content

Conversation

ChrisRackauckas
Copy link
Member

This reverts the JuliaFormatter changes from PR #3846 (commit 891793e).

The formatting is being reverted because JuliaFormatter had issues with line breaking that have now been addressed in JuliaFormatter.jl PR#933. Once that PR is merged and a new version is released, formatting can be reapplied with better results.

Note: This PR has [ci-skip] to avoid running tests since this is just reverting formatting changes.

This reverts commit 891793e.

Reverting JuliaFormatter changes due to formatting issues being addressed in JuliaFormatter.jl PR#933.
@ChrisRackauckas ChrisRackauckas merged commit d9bca37 into master Jul 31, 2025
38 of 50 checks passed
@ChrisRackauckas ChrisRackauckas deleted the revert-juliaformatter branch July 31, 2025 09:30
Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master a469380... master / a469380...
ODEProblem 0.0812 ± 0.0091 s 0.0809 ± 0.008 s 1 ± 0.15
init 0.0607 ± 0.0015 ms 0.061 ± 0.0014 ms 0.995 ± 0.033
large_parameter_init/ODEProblem 0.701 ± 0.0054 s 0.684 ± 0.012 s 1.02 ± 0.02
large_parameter_init/init 0.112 ± 0.002 ms 0.115 ± 0.0027 ms 0.98 ± 0.029
mtkcompile 0.0339 ± 0.00062 s 0.0342 ± 0.00099 s 0.994 ± 0.034
time_to_load 0.0169 ± 7.7e-05 h 0.0169 ± 6.7e-05 h 1 ± 0.006
Memory benchmarks
master a469380... master / a469380...
ODEProblem 0.588 M allocs: 20 MB 0.588 M allocs: 20 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.61 M allocs: 0.176 GB 4.61 M allocs: 0.177 GB 0.998
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.233 M allocs: 8.65 MB 0.233 M allocs: 8.63 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master a469380... master / a469380...
ODEProblem 0.0836 ± 0.0053 s 0.0837 ± 0.005 s 0.999 ± 0.087
init 0.0568 ± 0.012 ms 0.0576 ± 0.012 ms 0.986 ± 0.28
large_parameter_init/ODEProblem 0.756 ± 0.029 s 0.732 ± 0.027 s 1.03 ± 0.055
large_parameter_init/init 0.101 ± 0.011 ms 0.101 ± 0.012 ms 1 ± 0.16
mtkcompile 0.0362 ± 0.0013 s 0.0341 ± 0.00077 s 1.06 ± 0.044
time_to_load 0.0371 ± 0.00017 h 0.0359 ± 0.00034 h 1.03 ± 0.011
Memory benchmarks
master a469380... master / a469380...
ODEProblem 0.599 M allocs: 19.1 MB 0.599 M allocs: 19.1 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.76 M allocs: 0.171 GB 4.76 M allocs: 0.171 GB 1
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.24 M allocs: 8.19 MB 0.24 M allocs: 8.19 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant