Add nlstep_compile as a debug tool for turning off simplification #3873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used in order to test correctness and differences with the nlstep interface as it should exactly match the NonlinearSolveAlg
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ | |||
| t = nothing, eval_expression = false, eval_module = @__MODULE__, sparse = false, | |||
| steady_state = false, checkbounds = false, sparsity = false, analytic = nothing, | |||
| simplify = false, cse = true, initialization_data = nothing, expression = Val{false}, | |||
| check_compatibility = true, nlstep = false, kwargs...) where {iip, spec} | |||
| check_compatibility = true, nlstep = false, nlstep_compile = true, kwargs...) where {iip, spec} | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| check_compatibility = true, nlstep = false, nlstep_compile = true, kwargs...) where {iip, spec} | |
| check_compatibility = true, nlstep = false, nlstep_compile = true, kwargs...) where { | |
| iip, spec} |
| @@ -1,5 +1,5 @@ | |||
| function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sys)) | |||
| nlsys, outer_tmp, inner_tmp = inner_nlsystem(sys, mm) | |||
| function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sys), nlstep_compile::Bool = true) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sys), nlstep_compile::Bool = true) | |
| function generate_ODENLStepData( | |
| sys::System, u0, p, mm = calculate_massmatrix(sys), nlstep_compile::Bool = true) |
|
shouldn't this be labeled nlstep_simplify? |
|
Well we call it mtkcompile in v10, not structural_simplify. It should only be internal though, I don't think it should be documented since there isn't a user level reason to run nlstep without simplification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used in order to test correctness and differences with the nlstep interface as it should exactly match the NonlinearSolveAlg