Forward split to mtkcompile
#3875
Conversation
| @@ -198,10 +199,11 @@ function generate_control_function(sys::AbstractSystem, inputs = unbound_inputs( | |||
| simplify = false, | |||
| eval_expression = false, | |||
| eval_module = @__MODULE__, | |||
| split = true, | |||
There was a problem hiding this comment.
Introducing this argument with default true is likely breaking considering that the existing default in mtkcompile is false?
There was a problem hiding this comment.
I checked against MTK for the default.
ModelingToolkit.jl/src/systems/systems.jl
Line 31 in 873bf7e
There was a problem hiding this comment.
ah, I must have confused the meaning of split in my head, sorry about the noise then :)
There was a problem hiding this comment.
(I dislike having multiple places where a default is defined/ repeated since that can be error prone)
I don't know what pattern mtk follows for these cases if it has one.
There was a problem hiding this comment.
split=true is whether to use MTKParameters while putting everything into one vector. This has been the default for a bit now.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Ref #3859
Add any other context about the problem here.