Skip to content

feat: add SCCNonlinearProblem target for nlstep #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

feat: add SCCNonlinearProblem target for nlstep #3891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/problems/odeproblem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
t = nothing, eval_expression = false, eval_module = @__MODULE__, sparse = false,
steady_state = false, checkbounds = false, sparsity = false, analytic = nothing,
simplify = false, cse = true, initialization_data = nothing, expression = Val{false},
check_compatibility = true, nlstep = false, nlstep_compile = true, kwargs...) where {iip, spec}
check_compatibility = true, nlstep = false, nlstep_compile = true, nlstep_scc = false,
kwargs...) where {iip, spec}
check_complete(sys, ODEFunction)
check_compatibility && check_compatible_system(ODEFunction, sys)

Expand Down Expand Up @@ -42,7 +43,7 @@
_M = concrete_massmatrix(M; sparse, u0)

if nlstep
ode_nlstep = generate_ODENLStepData(sys, u0, p, M, nlstep_compile)
ode_nlstep = generate_ODENLStepData(sys, u0, p, M, nlstep_compile, nlstep_scc)
else
ode_nlstep = nothing
end
Expand Down
9 changes: 7 additions & 2 deletions src/systems/solver_nlprob.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sys), nlstep_compile::Bool = true)
function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sys),
nlstep_compile::Bool = true, nlstep_scc::Bool = false)
nlsys, outer_tmp, inner_tmp = inner_nlsystem(sys, mm, nlstep_compile)
state = ProblemState(; u = u0, p)
op = Dict()
Expand All @@ -12,7 +13,11 @@ function generate_ODENLStepData(sys::System, u0, p, mm = calculate_massmatrix(sy
haskey(op, v) && continue
op[v] = getsym(sys, v)(state)
end
nlprob = NonlinearProblem(nlsys, op; build_initializeprob = false)
nlprob = if nlstep_scc
SCCNonlinearProblem(nlsys, op; build_initializeprob = false)
else
NonlinearProblem(nlsys, op; build_initializeprob = false)
end

subsetidxs = [findfirst(isequal(y), unknowns(sys)) for y in unknowns(nlsys)]
set_gamma_c = setsym(nlsys, (ODE_GAMMA..., ODE_C))
Expand Down
Loading