Updated tests for the new behaviour of SymbolicUtils simplify function #3893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
simplify
from SymbolicUtils is gonna improve. PreviouslyBut now
This is going to break tests in ModelingToolkit/test/changeofvariables.jl because on line 138,
@test noise_eqs(new_sys)[2, 2] === value(substitute(2*α*y, backward_subs[2]))
is gonna be avaluated as2sqrt(w(t))*α === 2(w(t)^0.5)*α
returning false, becausenew_sys
comes fromchange_of_variables
function that contains asimplify
call.I tought of several options to fix this test:
@test noise_eqs(new_sys)[2, 2] === value(simplify(substitute(2*α*y, backward_subs[2])))
(what i did in this pr)simplify(noise_eqs(new_sys)[2, 2] - value(substitute(2*α*y, backward_subs[2])))===0
backward_subs = [x => exp(z), y => sqrt(w), u => exp(v)]
all of these work. I'd like some feedback :)