Skip to content

fix: fix callback with non-Real parameter and non-empty unknowns #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

fix: fix callback with non-Real parameter and non-empty unknowns #3894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/systems/callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ end
function default_operating_point(affsys::AffectSystem)
sys = system(affsys)

op = Dict(unknowns(sys) .=> 0.0)
op = AnyDict(unknowns(sys) .=> 0.0)
for p in parameters(sys)
T = symtype(p)
if T <: Number
Expand Down
19 changes: 19 additions & 0 deletions test/symbolic_events.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,3 +1421,22 @@ end
@named sys = System([D(y) ~ 2x + 1, x^2 ~ 2y^3], t; discrete_events = [dev])
sys = @test_nowarn mtkcompile(sys)
end

@testset "Non-`Real` symtype parameters in callback with unknown" begin
@mtkmodel MWE begin
@variables begin
x(t) = 1.0
end
@parameters begin
p(t)::Int = 1
end
@equations begin
D(x) ~ p * x
end
@discrete_events begin
1.0 => [x ~ p * Pre(x) * sin(x)]
end
end
@mtkcompile sys = MWE()
@test_nowarn ODEProblem(sys, [], (0.0, 1.0))
end
Loading