fix: let StochasticDiffEq auto calculate noise process #3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail |
|
yes this isn't correct since it's changing it from scalar to diagonal noise |
| # scalar noise | ||
| noise_rate_prototype = nothing | ||
| noise = WienerProcess(0.0, 0.0, 0.0) | ||
| noise = iip ? WienerProcess!(0., 0., 0.) : WienerProcess(0., 0., 0.) |
There was a problem hiding this comment.
Scalar is always out of place, since scalars are just numbers
There was a problem hiding this comment.
Ah OK I just misunderstood then, will close since the original issue is fixed by the rng change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #3971, but also lets it assign an in-place noise process for problems that are in-place instead of assuming out-of-place.