Skip to content

Prevents erroneous creation of discrete events (vector of conditions) #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
+19 −1
Merged

Prevents erroneous creation of discrete events (vector of conditions) #3992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f50214e
add manually throw error for wrong input
TorkelE Oct 26, 2025
66f1d31
add test
TorkelE Oct 26, 2025
dcec735
formatting
TorkelE Oct 26, 2025
7bfdf3b
remove wrong code
TorkelE Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/systems/callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,11 @@ function SymbolicDiscreteCallback(
condition::Union{Symbolic{Bool}, Number, Vector{<:Number}}, affect = nothing;
initialize = nothing, finalize = nothing,
reinitializealg = nothing, kwargs...)
c = is_timed_condition(condition) ? condition : value(scalarize(condition))
# Manual error check (to prevent events like `[X < 5.0] => [X ~ Pre(X) + 10.0]` from being created).
(condition isa Vector) && (eltype(condition) <: Num) &&
error("Vectors of symbolic conditions are not allowed for `SymbolicDiscreteCallback`.")

c = is_timed_condition(condition) ? condition : value(scalarize(condition))
if isnothing(reinitializealg)
if any(a -> a isa ImperativeAffect,
[affect, initialize, finalize])
Expand Down
15 changes: 15 additions & 0 deletions test/symbolic_events.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,3 +1440,18 @@ end
@mtkcompile sys = MWE()
@test_nowarn ODEProblem(sys, [], (0.0, 1.0))
end

@testset "Test erroneously created events yields errors" begin
@parameters p(t) d
@variables X(t)
@test_throws "Vectors of symbolic conditions are not allowed" SymbolicDiscreteCallback([X <
5.0] => [X ~
Pre(X) +
10.0])
@test_throws "Vectors of symbolic conditions are not allowed" SymbolicDiscreteCallback([
X < 5.0, X > 10.0] => [X ~ Pre(X) + 10.0])
@test_throws "MethodError: no method" SymbolicContinuousCallback((X <
5.0) => [X ~
Pre(X) +
10.0])
end
Loading