add test for passing params as structural params #3995
Merged
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is common to define composite systems, where the parameters and their names are defined in the "outer" system. Passing them as structural parameters ensures, that there is only one parameter holding that information (which can be changed with a callback for example) rather than having multiple parameters which just share the same default values.
|
Looks good! Unrelated, but thankfully I'm not going insane and InterfaceII running for hours isn't my fault in #3994 :D |
|
I guess all the failing stuff is unrelated, since the added test belong to Interface I and those run through. |
AayushSabharwal
approved these changes
Oct 29, 2025
|
Accidentally closed and reopened. Tests passed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in my context, it is very typical to define models based on subcomponents. However, the parameters still "belong" to the higher level model not to the lower level model. See #2714
A solution which works for me is to pass symbolic parameters of the outer system as structural parameters to the inner system. That works great, but might be off the beaten track and feels like the kind of feature which easily breaks by accident. This PR just adds a test case for that to detect accidental breakage before it breaks my whole model library 🙃