Adding Power, Modulo, UnaryMinus, Floor and Ceil blocks #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Feb 16, 2025
| @mtkmodel Power begin | ||
| @components begin | ||
| input1 = RealInput() | ||
| input2 = RealInput() # denominator can not be zero |
There was a problem hiding this comment.
these could have had better names, like exponent instead of input2
There was a problem hiding this comment.
True, could you follow up with some suggested names? It hasn't been released yet so it's still fine to change.
There was a problem hiding this comment.
base, power or base, exp?
There was a problem hiding this comment.
Added this PR here that updates names for the Modulo block as well : #359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
A few of the blocks developed for a parallel project being moved to the standard library