Fix Julia 1.12 deprecation warning for Pipe constructor #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue SciML#412 where Julia 1.12 triggers a warning during precompilation about the Pipe constructor being extended without explicit qualification. The warning occurred because `@deprecate Pipe Tube` was ambiguous - Julia couldn't determine if we were creating a new function or extending `Base.Pipe`. Fix: Added explicit `function Pipe end` declaration before the deprecation to clearly indicate we're creating a new generic function, not extending Base.Pipe. Fixes SciML#412 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #412 where Julia 1.12 triggers a deprecation warning during precompilation about the Pipe constructor being extended without explicit qualification.
Changes
function Pipe enddeclaration before@deprecate Pipe Tubeinsrc/Hydraulic/IsothermalCompressible/components.jlThe Problem
When compiling MTKSL under Julia 1.12, the following warning appeared:
The issue occurred because
@deprecate Pipe Tubewas ambiguous - Julia couldn't determine if we were creating a new function or extendingBase.Pipe.The Solution
By adding
function Pipe endbefore the deprecation, we explicitly declare that we're creating a new generic function namedPipe, not extendingBase.Pipe. This follows Julia 1.12's stricter requirements for function qualification.Testing
Closes #412
🤖 Generated with Claude Code