Remove local algo solution types

Author: utkarsh530

src/scalar.jl

@@ -52,12 +52,11 @@ end
 function SciMLBase.solve(prob::NonlinearProblem{<:Number, iip, <:Dual{T,V,P}}, alg::NewtonRaphson, args...; kwargs...) where {iip, T, V, P}
   sol, partials = scalar_nlsolve_ad(prob, alg, args...; kwargs...)
   return SciMLBase.build_solution(prob, alg, Dual{T,V,P}(sol.u, partials), sol.resid; retcode=sol.retcode)
-  #return NewtonSolution(Dual{T,V,P}(sol.u, partials), sol.retcode, sol.resid)
+  
 end
 function SciMLBase.solve(prob::NonlinearProblem{<:Number, iip, <:AbstractArray{<:Dual{T,V,P}}}, alg::NewtonRaphson, args...; kwargs...) where {iip, T, V, P}
   sol, partials = scalar_nlsolve_ad(prob, alg, args...; kwargs...)
   return SciMLBase.build_solution(prob, alg, Dual{T,V,P}(sol.u, partials), sol.resid; retcode=sol.retcode)
-  #return NewtonSolution(Dual{T,V,P}(sol.u, partials), sol.retcode, sol.resid)
 end
 
 # avoid ambiguities

src/solve.jl

@@ -66,11 +66,10 @@ function SciMLBase.solve!(solver::AbstractImmutableNonlinearSolver)
   if solver.iter == solver.maxiters
     @set! solver.retcode = MAXITERS_EXCEED
   end
-  sol = get_solution(solver)
-  if typeof(sol) <: NewtonSolution
-    SciMLBase.build_solution(solver.prob, solver.alg, getsolution(sol), sol.resid;retcode=Symbol(sol.retcode))
+  if typeof(solver) <: NewtonImmutableSolver
+    SciMLBase.build_solution(solver.prob, solver.alg, solver.u, solver.fu;retcode=Symbol(solver.retcode))
   else
-    SciMLBase.build_solution(solver.prob, solver.alg, getsolution(sol),sol.resid;retcode=Symbol(sol.retcode),left = sol.left,right = sol.right)
+    SciMLBase.build_solution(solver.prob, solver.alg, solver.left,solver.fl;retcode=Symbol(solver.retcode),left = solver.left,right = solver.right)
   end
 end
 
@@ -99,20 +98,6 @@ function mic_check(solver::NewtonImmutableSolver)
   solver
 end
 
-"""
-  get_solution(solver::Union{BracketingImmutableSolver, BracketingSolver})
-  get_solution(solver::Union{NewtonImmutableSolver, NewtonSolver})
-
-Form solution object from solver types
-"""
-function get_solution(solver::BracketingImmutableSolver)
-  return BracketingSolution(solver.left, solver.right, solver.retcode, solver.fl)
-end
-
-function get_solution(solver::NewtonImmutableSolver)
-  return NewtonSolution(solver.u, solver.retcode, solver.fu)
-end
-
 """
   reinit!(solver, prob)
 

src/types.jl

@@ -50,24 +50,9 @@ end
 #         typeof(fu), typeof(p), typeof(internalnorm), typeof(tol), typeof(cache)}(iter, f, alg, u, fu, p, force_stop, maxiters, internalnorm, retcode, tol, cache)
 # end
 
-struct BracketingSolution{uType,resType}
-    left::uType
-    right::uType
-    retcode::Retcode
-    resid::resType
-end
-
-struct NewtonSolution{uType,resType}
-    u::uType
-    retcode::Retcode
-    resid::resType
-end
 
 function sync_residuals!(solver::BracketingImmutableSolver)
     @set! solver.fl = solver.f(solver.left, solver.p)
     @set! solver.fr = solver.f(solver.right, solver.p)
     solver
-end
-
-getsolution(sol::NewtonSolution) = sol.u
-getsolution(sol::BracketingSolution) = sol.left
+end