Draft
Conversation
avik-pal
force-pushed
the
ap/opt
branch
2 times, most recently
from
b898160 to
94cab9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 81.16% 80.63% -0.54%
==========================================
Files 46 47 +1
Lines 2804 2850 +46
==========================================
+ Hits 2276 2298 +22
- Misses 528 552 +24 ☔ View full report in Codecov by Sentry. |
Member
|
Why not just add this code to OptmizationBase and document it here? |
Member
Author
|
That's probably a better way I will do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, this introduces a massive circular dependency if Optimization is loaded. But we only pay the price in CI rn.