Skip to content

fix: DI now works with ReverseDiff #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
+4 −7
Merged

fix: DI now works with ReverseDiff #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0f19a
fix: DI now works with ReverseDiff
avik-pal Sep 25, 2024
c9f3607
fix: remove stale dep
avik-pal Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/SciMLJacobianOperators/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
ConcreteStructs = "2569d6c7-a4a2-43d3-a901-331e8e4be471"
ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869"
FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
Expand All @@ -19,9 +18,8 @@ ADTypes = "1.8.1"
Aqua = "0.8.7"
ConcreteStructs = "0.2.3"
ConstructionBase = "1.5"
DifferentiationInterface = "0.6"
DifferentiationInterface = "0.6.1"
Enzyme = "0.12, 0.13"
EnzymeCore = "0.7, 0.8"
ExplicitImports = "1.9.0"
FastClosures = "0.3.2"
FiniteDiff = "2.24.0"
Expand Down
1 change: 0 additions & 1 deletion lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ using ADTypes: ADTypes, AutoSparse
using ConcreteStructs: @concrete
using ConstructionBase: ConstructionBase
using DifferentiationInterface: DifferentiationInterface, Constant
using EnzymeCore: EnzymeCore
using FastClosures: @closure
using LinearAlgebra: LinearAlgebra
using SciMLBase: SciMLBase, AbstractNonlinearProblem, AbstractNonlinearFunction
Expand Down
6 changes: 3 additions & 3 deletions lib/SciMLJacobianOperators/test/core_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
AutoEnzyme(),
AutoEnzyme(; mode = Enzyme.Reverse),
AutoZygote(),
# AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503
AutoReverseDiff(),
AutoTracker(),
AutoFiniteDiff()
]
Expand Down Expand Up @@ -91,7 +91,7 @@ end
reverse_ADs = [
AutoEnzyme(),
AutoEnzyme(; mode = Enzyme.Reverse),
# AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503
AutoReverseDiff(),
AutoFiniteDiff()
]

Expand Down Expand Up @@ -182,7 +182,7 @@ end
AutoEnzyme(; mode = Enzyme.Reverse),
AutoZygote(),
AutoTracker(),
# AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503
AutoReverseDiff(),
AutoFiniteDiff()
]

Expand Down
Loading