Skip to content

fix: don't use similar on prototype #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024
Merged

fix: don't use similar on prototype #474

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16d66b1
fix: don't use similar on prototype
avik-pal Oct 5, 2024
b5981e2
fix: use a copy
avik-pal Oct 5, 2024
834516a
fix: partial revert of previous fix
avik-pal Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NonlinearSolve"
uuid = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
authors = ["SciML"]
version = "3.15.0"
version = "3.15.1"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
10 changes: 5 additions & 5 deletions src/internal/jacobian.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ function JacobianCache(prob, alg, f::F, fu_, u, p; stats, autodiff = nothing,
end
end
else
jac_proto = if eltype(f.jac_prototype) <: Bool
similar(f.jac_prototype, promote_type(eltype(fu), eltype(u)))
if eltype(f.jac_prototype) <: Bool
jac_proto = similar(f.jac_prototype, promote_type(eltype(fu), eltype(u)))
fill!(jac_proto, false)
jac_proto
else
similar(f.jac_prototype)
f.jac_prototype
end
fill!(jac_proto, false)
jac_proto
end
end

Expand Down
Loading