Skip to content

Fix ambiguity in __solve with polyalgorithm due to dispatch on Va #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix ambiguity in __solve with polyalgorithm due to dispatch on Va #498

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6b3091
Fix ambiguity in `__solve` with polyalgorithm due to dispatch on `Val…
ChrisRackauckas Nov 12, 2024
88287ea
Update forward_ad_tests.jl
ChrisRackauckas Nov 12, 2024
1a77b03
Update lib/NonlinearSolveBase/src/solve.jl
ChrisRackauckas Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/NonlinearSolveBase/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ end
return Expr(:block, calls...)
end

@generated function SciMLBase.__solve(
function SciMLBase.__solve(prob::AbstractNonlinearProblem, alg::NonlinearSolvePolyAlgorithm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
function SciMLBase.__solve(prob::AbstractNonlinearProblem, alg::NonlinearSolvePolyAlgorithm,
function SciMLBase.__solve(
prob::AbstractNonlinearProblem, alg::NonlinearSolvePolyAlgorithm,

args...; kwargs...)
SciMLBase.__generated_polysolve(prob, alg, args...; kwargs...)
end

@generated function SciMLBase.__generated_polysolve(
prob::AbstractNonlinearProblem, alg::NonlinearSolvePolyAlgorithm{Val{N}}, args...;
stats = NLStats(0, 0, 0, 0, 0), alias_u0 = false, verbose = true, kwargs...
) where {N}
Expand Down
1 change: 1 addition & 0 deletions test/forward_ad_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ end
Broyden(),
Klement(),
DFSane(),
FastShortcutNonlinearPolyalg(),
nothing,
NLsolveJL(),
CMINPACK(),
Expand Down
Loading