refactor: Move RobustMultiNewton to NonlinearSolveFirstOrder #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Nov 12, 2024
|
Test failure looks unrelated. |
|
No it is related, it needs an implicit import |
avik-pal
reviewed
Nov 12, 2024
ErikQQY
force-pushed
the
qqy/move_robust
branch
from
01dab53 to
f43dc9a
Compare
ErikQQY
force-pushed
the
qqy/move_robust
branch
from
f43dc9a to
b0167af
Compare
|
The MTK tests are unrelated. @AayushSabharwal the MTK tests seem incorrect, no-init cache doesn't have |
|
NonlinearSolve caches don't follow their own interface 😅 I'll PR to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #494