Skip to content

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

@thazhemadam didn't you do a full disable of codecov?

@AayushSabharwal
Copy link
Member Author

@thazhemadam
Copy link
Member

thazhemadam commented Nov 13, 2024

It looks like NonlinearSolve.jl doesn't yet use the centralized CI setup (yet), because of the custom package dev-ing logic that runs before actually running the tests1.

In the meanwhile, 1242746 should fix these failures.

Footnotes

  1. https://github.com/SciML/NonlinearSolve.jl/blob/f0ec3437b3c21bb9f06148b88b42a1f59b5bc28e/.github/workflows/Downstream.yml#L35-L45

@ChrisRackauckas ChrisRackauckas merged commit 70c0581 into SciML:master Nov 13, 2024
70 of 93 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-sii branch November 14, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants