Skip to content

Add misc test group to NonlinearSolve CI to run QA tests #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2025
Merged

Add misc test group to NonlinearSolve CI to run QA tests #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85e5c04
Add misc test group to NonlinearSolve CI to run QA tests
ChrisRackauckas Mar 19, 2025
a826a45
Update NonlinearSolve.jl
ChrisRackauckas Mar 19, 2025
55f142d
Update NonlinearSolveNLSolversExt.jl
ChrisRackauckas Mar 19, 2025
2ba4774
Update NonlinearSolve.jl
ChrisRackauckas Mar 19, 2025
b160098
Update qa_tests.jl
ChrisRackauckas Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/CI_NonlinearSolve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
- core
- downstream
- wrappers
- misc
version:
- "1.10"
- "1"
Expand Down Expand Up @@ -95,6 +96,7 @@ jobs:
- core
- downstream
- wrappers
- misc
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand Down
1 change: 0 additions & 1 deletion ext/NonlinearSolveNLSolversExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module NonlinearSolveNLSolversExt

using ADTypes: ADTypes, AutoFiniteDiff, AutoForwardDiff, AutoPolyesterForwardDiff
using DifferentiationInterface: DifferentiationInterface, Constant
using FastClosures: @closure

Expand Down
11 changes: 4 additions & 7 deletions src/NonlinearSolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,14 @@ using FastClosures: @closure

using ADTypes: ADTypes
using ArrayInterface: ArrayInterface
using CommonSolve: CommonSolve, solve, solve!
using CommonSolve: CommonSolve, init, solve, solve!
using DiffEqBase: DiffEqBase # Needed for `init` / `solve` dispatches
using LinearAlgebra: LinearAlgebra, norm
using LinearAlgebra: LinearAlgebra
using LineSearch: BackTracking
using NonlinearSolveBase: NonlinearSolveBase, InternalAPI, AbstractNonlinearSolveAlgorithm,
AbstractNonlinearSolveCache, Utils, L2_NORM,
enable_timer_outputs, disable_timer_outputs,
using NonlinearSolveBase: NonlinearSolveBase, AbstractNonlinearSolveAlgorithm,
NonlinearSolvePolyAlgorithm, pickchunksize

using Preferences: set_preferences!
using SciMLBase: SciMLBase, NLStats, ReturnCode, AbstractNonlinearProblem,
using SciMLBase: SciMLBase, ReturnCode, AbstractNonlinearProblem,
NonlinearFunction,
NonlinearProblem, NonlinearLeastSquaresProblem, NoSpecialize
using SymbolicIndexingInterface: SymbolicIndexingInterface
Expand Down
4 changes: 3 additions & 1 deletion test/qa_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
@testitem "Aqua" tags=[:misc] begin
using NonlinearSolve, SimpleNonlinearSolve, Aqua

Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false)
Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false, stale_deps = false, deps_compat = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false, stale_deps = false, deps_compat = false)
Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false,
stale_deps = false, deps_compat = false)

Aqua.test_ambiguities(NonlinearSolve; recursive = false)
Aqua.test_stale_deps(SimpleNonlinearSolve; ignore = [:SciMLJacobianOperators])
Aqua.test_deps_compat(SimpleNonlinearSolve; ignore = [:SciMLJacobianOperators])
Aqua.test_piracies(NonlinearSolve,
treat_as_own = [
NonlinearProblem, NonlinearLeastSquaresProblem, SciMLBase.AbstractNonlinearProblem,
Expand Down
Loading