Skip to content

Fix handling of singular Jacobians in default solver #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix handling of singular Jacobians in default solver #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/poly_algs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,16 @@ function FastShortcutNonlinearPolyalg(
) where {T}
start_index = 1
common_kwargs = (; concrete_jac, linsolve, autodiff, vjp_autodiff, jvp_autodiff)
common_kwargs_nocj = (; linsolve, autodiff, vjp_autodiff, jvp_autodiff)
if must_use_jacobian isa Val{true}
if T <: Complex
algs = (NewtonRaphson(; common_kwargs...),)
else
algs = (
NewtonRaphson(; common_kwargs...),
TrustRegion(; common_kwargs...),
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin)
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin),
LevenbergMarquardt(; common_kwargs_nocj...)
)
end
else
Expand All @@ -61,7 +63,8 @@ function FastShortcutNonlinearPolyalg(
SimpleKlement(),
NewtonRaphson(; common_kwargs...),
TrustRegion(; common_kwargs...),
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin)
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin),
LevenbergMarquardt(; common_kwargs_nocj...)
)
end
else
Expand All @@ -79,7 +82,8 @@ function FastShortcutNonlinearPolyalg(
Klement(; linsolve, autodiff),
NewtonRaphson(; common_kwargs...),
TrustRegion(; common_kwargs...),
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin)
TrustRegion(; common_kwargs..., radius_update_scheme = RUS.Bastin),
LevenbergMarquardt(; common_kwargs_nocj...)
)
end
end
Expand Down
7 changes: 7 additions & 0 deletions test/core_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,4 +435,11 @@ end
sol = solve(prob)
@test SciMLBase.successful_retcode(sol)
@test sol.retcode == ReturnCode.StalledSuccess
end

@testitem "Default Algorithm Singular Handling" tags=[:core] begin
f(u, p) = [u[1]^2 - 2u[1] + 1, sum(u)]
prob = NonlinearProblem(f, [1.0, 1.0])
sol = solve(prob)
@test SciMLBase.successful_retcode(sol)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
end
end

Loading