Remove debugging macros in reinit! due to overhead
#641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up having a lot of overhead found in SciML/OrdinaryDiffEq.jl#2757. They are triggered because the `reinit!` code recursively `reinit!`s the internals of the cache, and `LinearCache` doesn't have a `reinit!`, so it's a no-op. This is correct, but it turns out the debugging macro is just really expensive so it makes it slow even though it's not doing anything 😅 . I commented it out so we know where to put SciMLVerbosity.jl instructions for the near future @jClugstor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up having a lot of overhead found in SciML/OrdinaryDiffEq.jl#2757. They are triggered because the
reinit!code recursivelyreinit!s the internals of the cache, andLinearCachedoesn't have areinit!, so it's a no-op. This is correct, but it turns out the debugging macro is just really expensive so it makes it slow even though it's not doing anything 😅 . I commented it out so we know where to put SciMLVerbosity.jl instructions for the near future @jClugstor