Fix subpackage source definitions and test parsing errors #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing [sources] sections for SciMLJacobianOperators in NonlinearSolveBase and NonlinearSolveFirstOrder - Add missing dependencies and [sources] section for SCCNonlinearSolve (NonlinearSolve, NonlinearSolveBase, NonlinearSolveFirstOrder) - Update all inter-repo dependency compat entries to current versions - Bump minor version for all packages: - NonlinearSolve: 4.10.0 -> 4.11.0 - BracketingNonlinearSolve: 1.3.0 -> 1.4.0 - NonlinearSolveBase: 1.14.0 -> 1.15.0 - NonlinearSolveFirstOrder: 1.7.0 -> 1.8.0 - NonlinearSolveHomotopyContinuation: 0.1.5 -> 0.2.0 - NonlinearSolveQuasiNewton: 1.8.0 -> 1.9.0 - NonlinearSolveSciPy: 1.0.0 -> 1.1.0 - NonlinearSolveSpectralMethods: 1.3.0 -> 1.4.0 - SCCNonlinearSolve: 1.4.0 -> 1.5.0 - SciMLJacobianOperators: 0.1.8 -> 0.2.0 - SimpleNonlinearSolve: 2.7.0 -> 2.8.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Only add [sources] section for test dependencies, not new deps 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The PR incorrectly bumped sublibrary versions to their next versions (what they would be after the PR merges) instead of their current latest release versions. This commit reverts all sublibrary versions to their correct current release versions: - BracketingNonlinearSolve: 1.4.0 → 1.3.0 - NonlinearSolveBase: 1.15.0 → 1.14.0 - NonlinearSolveFirstOrder: 1.8.0 → 1.7.0 - NonlinearSolveHomotopyContinuation: 0.2.0 → 0.1.5 - NonlinearSolveQuasiNewton: 1.9.0 → 1.8.0 - NonlinearSolveSciPy: 1.1.0 → 1.0.0 - NonlinearSolveSpectralMethods: 1.4.0 → 1.3.0 - SCCNonlinearSolve: 1.5.0 → 1.4.0 - SciMLJacobianOperators: 0.1.9 → 0.1.8 - SimpleNonlinearSolve: 2.8.0 → 2.7.0 Also updated the corresponding compat bounds in the main Project.toml file.
The [sources] section should be a single section with all sources listed as key-value pairs, not separate [sources.PackageName] subsections.
Add try-catch blocks to handle cases where Hwloc.num_physical_cores() or Hwloc.num_virtual_cores() might fail or return invalid values. This prevents the 'input string is empty or only contains whitespace' error when parsing the default values for RETESTITEMS_NWORKERS and RETESTITEMS_NWORKER_THREADS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues found in #676:
Fixed sources section format in subpackage Project.toml files
[sources]section should be a single section with all sources listed as key-value pairs[sources.PackageName]format in:Fixed parse error in test/runtests.jl
Hwloc.num_physical_cores()orHwloc.num_virtual_cores()might failTest plan
Related to #676
🤖 Generated with Claude Code