Skip to content

Use correct constructors for JacobianOperators in copy #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

Use correct constructors for JacobianOperators in copy #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,8 @@ function get_dense_ad(ad::AutoSparse)
return dense_ad
end

function Base.copy(J::JacobianOperator)
return JacobianOperator(
function Base.copy(J::JacobianOperator{iip, T}) where {iip, T}
return JacobianOperator{iip,T}(
J.mode,
J.jvp_op,
J.vjp_op,
Expand All @@ -423,8 +423,8 @@ function Base.copy(J::StatefulJacobianOperator)
)
end

function Base.copy(J::StatefulJacobianNormalFormOperator)
return StatefulJacobianNormalFormOperator(
function Base.copy(J::StatefulJacobianNormalFormOperator{T}) where {T}
return StatefulJacobianNormalFormOperator{T}(
J.vjp_operator === nothing ? nothing : copy(J.vjp_operator),
J.jvp_operator === nothing ? nothing : copy(J.jvp_operator),
J.cache === nothing ? nothing : copy(J.cache)
Expand Down
Loading