Skip to content

Fix: reinit! error when using AbsTerminationMode #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2025
+22 −4
Merged

Fix: reinit! error when using AbsTerminationMode #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7329de1
Fix: reinit! error when using AbsTerminationMode
AJ0070 Sep 6, 2025
1341e76
Merge branch 'master' into fix/687
AJ0070 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/NonlinearSolveBase/src/termination_conditions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,12 @@ function SciMLBase.reinit!(
length(saved_value_prototype) != 0 && (cache.saved_values = saved_value_prototype)

mode = cache.mode
if u isa Number || !ArrayInterface.can_setindex(u)
cache.u = u
else
cache.u .= u
if cache.u !== nothing
if u isa Number || !ArrayInterface.can_setindex(u)
cache.u = u
else
cache.u .= u
end
end
cache.retcode = ReturnCode.Default

Expand Down
16 changes: 16 additions & 0 deletions lib/NonlinearSolveBase/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,20 @@ using InteractiveUtils, Test

@test NonlinearSolveBase.Utils.faster_vcat(b, d) == vcat(sparse(b), d)
end

@testset "Termination Conditions" begin
using NonlinearSolveBase, SciMLBase
@testset "reinit! with AbsTerminationMode" begin
mode = NonlinearSolveBase.AbsTerminationMode()
u_unaliased = nothing
T = Float64
cache = NonlinearSolveBase.NonlinearTerminationModeCache(
u_unaliased, SciMLBase.ReturnCode.Default, 1e-8, 1e-8, Inf, mode,
nothing, nothing, 0, nothing, nothing, nothing, nothing, nothing, false
)
du = [1.0, 1.0]
u = [1.1, 1.1]
@test_nowarn SciMLBase.reinit!(cache, du, u)
end
end
end
Loading