Add compatibility support for supports_opt_cache_interface #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates all uses of supports_opt_cache_interface to check for availability in both SciMLBase and OptimizationBase packages, ensuring compatibility regardless of which package defines the function. Changes made: - Updated all optimization algorithm packages to use isdefined checks - Applied to both simple single-line and complex macro-generated definitions - Covers 20+ files across the entire optimization ecosystem This addresses compatibility issues where supports_opt_cache_interface might be defined in either SciMLBase or OptimizationBase depending on version combinations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changed from elseif to separate if statements to ensure both SciMLBase and OptimizationBase compatibility patterns are defined when both packages are available. This allows the supports_opt_cache_interface function to be defined for algorithms in both packages simultaneously, providing better compatibility coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changed all isdefined checks to @static if for better performance since these conditions can be evaluated at compile time. This ensures the supports_opt_cache_interface compatibility checks are resolved during compilation rather than runtime, providing optimal performance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Version bumps for compatibility changes: - Optimization.jl: 4.6.0 → 4.7.0 (minor bump) - OptimizationBBO: 0.4.1 → 0.4.2 - OptimizationCMAEvolutionStrategy: 0.3.1 → 0.3.2 - OptimizationEvolutionary: 0.4.1 → 0.4.2 - OptimizationGCMAES: 0.3.0 → 0.3.1 - OptimizationIpopt: 0.1.1 → 0.1.2 - OptimizationManopt: 0.0.4 → 0.0.5 - OptimizationMetaheuristics: 0.3.0 → 0.3.1 - OptimizationMOI: 0.5.5 → 0.5.6 - OptimizationMultistartOptimization: 0.3.0 → 0.3.1 - OptimizationNLopt: 0.3.2 → 0.3.3 - OptimizationODE: 0.1.0 → 0.1.1 - OptimizationOptimisers: 0.3.9 → 0.3.10 - OptimizationOptimJL: 0.4.3 → 0.4.4 - OptimizationPRIMA: 0.3.0 → 0.3.1 - OptimizationPyCMA: 1.0.0 → 1.1.0 (minor bump) - OptimizationSciPy: 0.4.1 → 0.4.2 - OptimizationSpeedMapping: 0.2.0 → 0.2.1 Following semver convention: for 0.x.y increment patch (y), for x.y.z where x≥1 increment minor (y). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all uses of
supports_opt_cache_interfaceacross the Optimization.jl ecosystem to check for availability in bothSciMLBaseandOptimizationBasepackages, ensuring compatibility regardless of which package defines the function.Changes Made
Files Modified
Core algorithms:
src/lbfgsb.jlsrc/sophia.jlsrc/auglag.jlOptimization libraries:
lib/OptimizationOptimJL/src/OptimizationOptimJL.jllib/OptimizationMetaheuristics/src/OptimizationMetaheuristics.jllib/OptimizationGCMAES/src/OptimizationGCMAES.jllib/OptimizationCMAEvolutionStrategy/src/OptimizationCMAEvolutionStrategy.jllib/OptimizationEvolutionary/src/OptimizationEvolutionary.jllib/OptimizationBBO/src/OptimizationBBO.jllib/OptimizationSciPy/src/OptimizationSciPy.jllib/OptimizationMultistartOptimization/src/OptimizationMultistartOptimization.jllib/OptimizationODE/src/OptimizationODE.jllib/OptimizationMOI/src/OptimizationMOI.jllib/OptimizationIpopt/src/OptimizationIpopt.jllib/OptimizationPRIMA/src/OptimizationPRIMA.jllib/OptimizationManopt/src/OptimizationManopt.jllib/OptimizationOptimisers/src/OptimizationOptimisers.jllib/OptimizationSpeedMapping/src/OptimizationSpeedMapping.jllib/OptimizationNLopt/src/OptimizationNLopt.jllib/OptimizationPyCMA/src/OptimizationPyCMA.jlProblem Solved
This addresses compatibility issues where
supports_opt_cache_interfacemight be defined in eitherSciMLBaseorOptimizationBasedepending on package version combinations. The compatibility layer ensures that both versions work correctly for all optimization algorithms.Previously, all files used:
Now they use the compatibility pattern that checks both packages, ensuring the function works regardless of where it's defined.
Test Plan
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]