Skip to content

Better handling of Base method movement #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Better handling of Base method movement #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
330dd6e
Better handling of Base method movement
ChrisRackauckas Oct 15, 2025
ffd24bb
full split
ChrisRackauckas Oct 15, 2025
f827514
put out fix
ChrisRackauckas Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OptimizationBase/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "OptimizationBase"
uuid = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
authors = ["Vaibhav Dixit <[email protected]> and contributors"]
version = "3.2.0"
version = "3.3.0"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
8 changes: 3 additions & 5 deletions lib/OptimizationBase/src/OptimizationBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ import SciMLBase: solve, init, solve!, __init, __solve,
requireshessian, requiresconsjac,
requiresconshess

@static if isdefined(SciMLBase, :supports_opt_cache_interface)
import SciMLBase: supports_opt_cache_interface
else
supports_opt_cache_interface(alg) = false
supports_opt_cache_interface(alg) = false
@static if !hasmethod(SciMLBase.__solve, Tuple{OptimizationProblem, SciMLBase.AbstractOptimizationAlgorithm})
include("solve.jl")
end

export ObjSense, MaxSense, MinSense
Expand All @@ -40,7 +39,6 @@ Base.length(::NullData) = 0
include("adtypes.jl")
include("symify.jl")
include("cache.jl")
include("solve.jl")
include("OptimizationDIExt.jl")
include("OptimizationDISparseExt.jl")
include("function.jl")
Expand Down
2 changes: 1 addition & 1 deletion lib/OptimizationBase/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ from NLopt for an example. The common local optimizer arguments are:
"""
function solve(prob::SciMLBase.OptimizationProblem, alg, args...;
kwargs...)::SciMLBase.AbstractOptimizationSolution
if supports_opt_cache_interface(alg)
if SciMLBase.supports_opt_cache_interface(alg)
solve!(init(prob, alg, args...; kwargs...))
else
if prob.u0 !== nothing && !isconcretetype(eltype(prob.u0))
Expand Down
Loading