Bugfix #1069
Merged
Bugfix #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claude <[email protected]>
The Lagrangian Hessian prototype was incorrectly sized as (num_constraints × num_variables) instead of (num_variables × num_variables). This caused a `BoundsError` when computing the Lagrangian Hessian with more variables than constraints, as the prototype was used as a buffer for the n×n Hessian matrix. Changes: - Fix lag_hess_prototype initialization to use zeros(Bool, length(x), length(x)) - Add comprehensive tests to verify prototype dimensions and usability as a buffer This ensures the Lagrangian Hessian is always correctly sized as n×n regardless of the number of constraints, matching the mathematical definition of the Lagrangian Hessian as the second derivative with respect to the decision variables. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The Lagrangian Hessian prototype was incorrectly sized as (num_constraints × num_variables) instead of (num_variables × num_variables). This caused a `BoundsError` when computing the Lagrangian Hessian with more variables than constraints, as the prototype was used as a buffer for the n×n Hessian matrix. Changes: - Fix lag_hess_prototype initialization to use zeros(Bool, length(x), length(x)) in both in-place and out-of-place function instantiation - Add tests to verify prototype dimensions This ensures the Lagrangian Hessian is always correctly sized as n×n regardless of the number of constraints, matching the mathematical definition of the Lagrangian Hessian as the second derivative with respect to the decision variables. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Corrected function name to properly spell VJP (Vector-Jacobian Product). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several bugs
ReInitCacheis usedallowconsvjpChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Splits off bugfixes from #1061