Skip to content

Update OptimizationOptimJL.jl #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Update OptimizationOptimJL.jl #895

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f57786
Update OptimizationOptimJL.jl
Vaibhavdixit02 Apr 7, 2025
d9a1f19
Update lib/OptimizationOptimJL/src/OptimizationOptimJL.jl
Vaibhavdixit02 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/OptimizationOptimJL/src/OptimizationOptimJL.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ function __map_optimizer_args(cache::OptimizationCache,
abstol::Union{Number, Nothing} = nothing,
reltol::Union{Number, Nothing} = nothing,
kwargs...)
if !isnothing(abstol)
@warn "common abstol is currently not used by $(opt)"
end

mapped_args = (; extended_trace = true, kwargs...)

if !isnothing(abstol)
mapped_args = (; mapped_args..., f_abstol = reltol)
Copy link

@axla-io axla-io Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Should it be f_abstol = abstol here?

end

if !isnothing(callback)
mapped_args = (; mapped_args..., callback = callback)
end
Expand Down Expand Up @@ -72,7 +73,7 @@ function __map_optimizer_args(cache::OptimizationCache,
end

if !isnothing(reltol)
mapped_args = (; mapped_args..., f_tol = reltol)
mapped_args = (; mapped_args..., f_reltol = reltol)
end

return Optim.Options(; mapped_args...)
Expand Down
Loading