Skip to content

define maxiters similar to epochs #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 20, 2025
Merged

define maxiters similar to epochs #897

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da12a24
define `maxiters` similar to `epochs`
prbzrg Apr 12, 2025
e96800d
better organization of the codes
prbzrg Apr 19, 2025
cc03eae
add types to the kwargs
prbzrg Apr 19, 2025
075bc0f
check for right numbers
prbzrg Apr 19, 2025
28302c8
add tests
prbzrg Apr 19, 2025
243f848
Update lib/OptimizationOptimisers/src/OptimizationOptimisers.jl
prbzrg Apr 19, 2025
692b660
add messages to the error types in tests
prbzrg Apr 19, 2025
5926cd8
fix errors
prbzrg Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/OptimizationOptimisers/src/OptimizationOptimisers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,19 @@ function SciMLBase.__solve(cache::OptimizationCache{
else
cache.solver_args.epochs
end
maxiters = if cache.solver_args.maxiters === nothing
if cache.solver_args.epochs === nothing
throw(ArgumentError("The number of iterations must be specified with either the epochs or maxiters kwarg. Where maxiters = epochs*length(data)."))
else
cache.solver_args.epochs * length(data)
end
else
cache.solver_args.maxiters
end

epochs = Optimization._check_and_convert_maxiters(epochs)
if epochs === nothing
maxiters = Optimization._check_and_convert_maxiters(maxiters)
if epochs === nothing || maxiters === nothing
throw(ArgumentError("The number of iterations must be specified with either the epochs or maxiters kwarg. Where maxiters = epochs*length(data)."))
end

Expand Down
Loading