Simplify calls to Optim.jl #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of the complexity in the issues with the Optim.jl wrapper is simply because it doesn't treat Optim well. It makes things always complete, instead of simplifying the call. This simplifies the call, so the less you use the less machinery is required. In particular: * TwiceDifferentiable is only made and used if the optimizer needs to use Hessians. This fixes #859, fixes #893 * Only uses constraints and bounds when the user sets them. Fixes #863 and fixes #558
ChrisRackauckas
commented
May 6, 2025
ChrisRackauckas
commented
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the complexity in the issues with the Optim.jl wrapper is simply because it doesn't treat Optim well. It makes things always complete, instead of simplifying the call. This simplifies the call, so the less you use the less machinery is required. In particular:
Fminboxincase of box constraints necessitates gradient #558